Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Revert banana RID source build changes from arcade #78362

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented Nov 15, 2022

I had originally restored these lines in the arcade dependencies update PR with this commit, but a subsequent automated update reverted my commit. Since the CI had already finished with all the concerns resolved, I didn't want to restart the CI, and instead I'm sending this in a separate change.

This was also addressed directly in the arcade repo: dotnet/arcade#11604 but this PR is to unblock us for now. /cc @ayakael

@ghost ghost assigned carlossanlop Nov 15, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Nov 15, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

I had originally restored these lines in the arcade dependencies update PR with this commit, but a subsequent automated update reverted my commit. Since the CI had already finished with all the concerns resolved, I didn't want to restart the CI, and instead I'm sending this in a separate change.

This was also addressed directly in the arcade repo: dotnet/arcade#11604 but this PR is to unblock us for now.

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure

Milestone: -

@ayakael
Copy link
Contributor

ayakael commented Nov 15, 2022

Memory serves, this was removed from #77508 and pushed off to arcade after CIs were green. So I reckon that the currently failing test units are infrastructure issues.

@ayakael
Copy link
Contributor

ayakael commented Nov 15, 2022

Could this be merged to unblock dotnet/installer#14816?

@mmitche
Copy link
Member

mmitche commented Nov 15, 2022

@carlossanlop The next arcade update (should be about 45 mins away) has this fix. I can trigger it just for runtime.

@carlossanlop
Copy link
Member Author

@carlossanlop The next arcade update (should be about 45 mins away) has this fix. I can trigger it just for runtime.

That would be awesome, yes.

@carlossanlop
Copy link
Member Author

Closing in favor of the upcoming arcade update PR.

@carlossanlop carlossanlop deleted the RevertBananaSourceBuildChange branch November 15, 2022 22:21
@ghost ghost locked as resolved and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants